Browse / AI Framework and Platform Flaws / CVE-2021-29558
Heap buffer overflow in `SparseSplit`
- Class
- AI Framework and Platform Flaws (filed by a model that read the source)
- Technique
- Memory corruption
- Affected
- tensorflow-cpu, tensorflow (PyPI)
- CVSS
- CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L
- EPSS
- 0.2% chance of exploitation in 30 days
How it works, in short
A user-controlled split dimension index is used to access an array without bounds checks, letting SparseSplit write past a heap buffer. (Our summary, written by a model. The source text is below.)
Details
Impact
An attacker can cause a heap buffer overflow in tf.raw_ops.SparseSplit:
import tensorflow as tf
shape_dims = tf.constant(0, dtype=tf.int64)
indices = tf.ones([1, 1], dtype=tf.int64)
values = tf.ones([1], dtype=tf.int64)
shape = tf.ones([1], dtype=tf.int64)
tf.raw_ops.SparseSplit(
split_dim=shape_dims, indices=indices, values=values,
shape=shape, num_split=1)
This is because the implementation accesses an array element based on a user controlled offset:
const int dim = input_tensor.indices().matrix<int64>()(i, split_dim);
int slice_index = GetSliceIndex(dim, split_size, residual);
num_values[slice_index]++;
This results in overriding values on the heap.
Patches
We have patched the issue in GitHub commit 8ba6fa29cd8bf9cef9b718dc31c78c73081f5b31.
The fix will be included in TensorFlow 2.5.0. We will also cherrypick this commit on TensorFlow 2.4.2, TensorFlow 2.3.3, TensorFlow 2.2.3 and TensorFlow 2.1.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by Ying Wang and Yakun Zhang of Baidu X-Team.
References
- https://github.com/tensorflow/tensorflow/security/advisories/GHSA-mqh2-9wrp-vx84
- https://nvd.nist.gov/vuln/detail/CVE-2021-29558
- https://github.com/tensorflow/tensorflow/commit/8ba6fa29cd8bf9cef9b718dc31c78c73081f5b31
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-cpu/PYSEC-2021-486.yaml
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-gpu/PYSEC-2021-684.yaml
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow/PYSEC-2021-195.yaml
- https://github.com/tensorflow/tensorflow
Source: GitHub Advisory Database, used under CC BY 4.0.