CASEBOOK

Browse / AI Framework and Platform Flaws / CVE-2021-29515

Reference binding to null pointer in `MatrixDiag*` ops

CVE-2021-29515 ยท 2021-05-21 low

Class
AI Framework and Platform Flaws (filed by a model that read the source)
Technique
Denial of service
Affected
tensorflow-cpu, tensorflow (PyPI)
CVSS
CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L
EPSS
0.2% chance of exploitation in 30 days

How it works, in short

Matrix diagonal ops dereference empty tensor inputs without checking them, causing a null pointer crash. (Our summary, written by a model. The source text is below.)

Details

Impact

The implementation of MatrixDiag* operations does not validate that the tensor arguments are non-empty:

      num_rows = context->input(2).flat<int32>()(0);
      num_cols = context->input(3).flat<int32>()(0);
      padding_value = context->input(4).flat<T>()(0); 

Thus, users can trigger null pointer dereferences if any of the above tensors are null:

import tensorflow as tf

d = tf.convert_to_tensor([],dtype=tf.float32)
p = tf.convert_to_tensor([],dtype=tf.float32)
tf.raw_ops.MatrixDiagV2(diagonal=d, k=0, num_rows=0, num_cols=0, padding_value=p)

Changing from tf.raw_ops.MatrixDiagV2 to tf.raw_ops.MatrixDiagV3 still reproduces the issue.

Patches

We have patched the issue in GitHub commit a7116dd3913c4a4afd2a3a938573aa7c785fdfc6.

The fix will be included in TensorFlow 2.5.0. We will also cherrypick this commit on TensorFlow 2.4.2, TensorFlow 2.3.3, TensorFlow 2.2.3 and TensorFlow 2.1.4, as these are also affected and still in supported range.

For more information

Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution

This vulnerability has been reported by Ye Zhang and Yakun Zhang of Baidu X-Team.

References

Source: GitHub Advisory Database, used under CC BY 4.0.