MISFIRE

Browse / AI Framework and Platform Flaws / CVE-2021-37658

Reference binding to nullptr in `MatrixSetDiagV*` ops

CVE-2021-37658 ยท 2021-08-25 moderate

Class
AI Framework and Platform Flaws (filed by a model that read the source)
Technique
Memory corruption
Affected
tensorflow-cpu, tensorflow (PyPI)
CVSS
CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H
EPSS
0.2% chance of exploitation in 30 days

How it works, in short

An empty tensor passed as the diagonal offset makes code read its first element through a null reference, causing undefined behaviour. (Our summary, written by a model. The source text is below.)

Details

Impact

An attacker can cause undefined behavior via binding a reference to null pointer in all operations of type tf.raw_ops.MatrixSetDiagV*:

import tensorflow as tf

tf.raw_ops.MatrixSetDiagV3(
  input=[1,2,3],
  diagonal=[1,1],
  k=[],
  align='RIGHT_LEFT')

The implementation has incomplete validation that the value of k is a valid tensor. We have check that this value is either a scalar or a vector, but there is no check for the number of elements. If this is an empty tensor, then code that accesses the first element of the tensor is wrong:

  auto& diag_index = context->input(1);
  ...
  lower_diag_index = diag_index.flat<int32>()(0);

Patches

We have patched the issue in GitHub commit ff8894044dfae5568ecbf2ed514c1a37dc394f1b.

The fix will be included in TensorFlow 2.6.0. We will also cherrypick this commit on TensorFlow 2.5.1, TensorFlow 2.4.3, and TensorFlow 2.3.4, as these are also affected and still in supported range.

For more information

Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution

This vulnerability has been reported by members of the Aivul Team from Qihoo 360.

References

Source: GitHub Advisory Database, used under CC BY 4.0.