Browse / Unsafe Model Loading and Supply Chain / GHSA-vqmv-47xg-9wpr
Picklescan missing detection when calling pty.spawn
- Class
- Unsafe Model Loading and Supply Chain (filed by a model that read the advisory)
- Technique
- Code and command execution
- Affected
- picklescan (PyPI)
- Gets past
- Safe model loader or scanner
- CVSS
- CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N/E:P
How it works, in short
A pickle's __reduce__ calls pty.spawn to run shell commands, and picklescan does not flag pty.spawn, so the scan reports the file as clean. (Our summary, written by a model. The source text is below.)
Details
Summary
Using pty.spawn, which is a built-in python library function to execute arbitrary commands on the host system.
Details
The attack payload executes in the following steps: First, the attacker craft the payload by calling to pty.spawn function in the __reduce__ method. Then the victim attempts to use picklescan to scan the pickle file for issues and sees this -
----------- SCAN SUMMARY -----------
Scanned files: 1
Infected files: 0
Dangerous globals: 0
The victim proceeds to load the pickle file and execute attacker-injected arbitrary code.
PoC
class PtyExploit:
def __reduce__(self):
return (pty.spawn, (["/bin/sh", "-c", "id; exit"],))
Impact
Who is impacted? Any organization or individual relying on picklescan to detect malicious pickle files inside PyTorch models. What is the impact? Attackers can embed malicious code in pickle file that remains undetected but executes when the pickle file is loaded. Supply Chain Attack: Attackers can distribute infected pickle files across ML models, APIs, or saved Python objects.
Collaborators
https://github.com/ajohnston9 https://github.com/geo-lit
References
- https://github.com/mmaitre314/picklescan/security/advisories/GHSA-vqmv-47xg-9wpr
- https://github.com/mmaitre314/picklescan/pull/53
- https://github.com/mmaitre314/picklescan/commit/70c1c6c31beb6baaf52c8db1b6c3c0e84a6f9dab
- https://github.com/mmaitre314/picklescan
- https://github.com/mmaitre314/picklescan/releases/tag/v0.0.33
Source: GitHub Advisory Database, used under CC BY 4.0.