Browse / Unsafe Model Loading and Supply Chain / CVE-2021-29605
Integer overflow in TFLite memory allocation
- Class
- Unsafe Model Loading and Supply Chain (filed by a model that read the source)
- Technique
- Memory corruption
- Affected
- tensorflow-cpu, tensorflow (PyPI)
- CVSS
- CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H
- EPSS
- 0.2% chance of exploitation in 30 days
How it works, in short
A crafted TFLite model makes an integer size calculation overflow, so malloc receives a negative size and later memory access goes out of bounds. (Our summary, written by a model. The source text is below.)
Details
Impact
The TFLite code for allocating TFLiteIntArrays is vulnerable to an integer overflow issue:
int TfLiteIntArrayGetSizeInBytes(int size) {
static TfLiteIntArray dummy;
return sizeof(dummy) + sizeof(dummy.data[0]) * size;
}
An attacker can craft a model such that the size multiplier is so large that the return value overflows the int datatype and becomes negative. In turn, this results in invalid value being given to malloc:
TfLiteIntArray* TfLiteIntArrayCreate(int size) {
TfLiteIntArray* ret = (TfLiteIntArray*)malloc(TfLiteIntArrayGetSizeInBytes(size));
ret->size = size;
return ret;
}
In this case, ret->size would dereference an invalid pointer.
Patches
We have patched the issue in GitHub commit 7c8cc4ec69cd348e44ad6a2699057ca88faad3e5.
The fix will be included in TensorFlow 2.5.0. We will also cherrypick this commit on TensorFlow 2.4.2, TensorFlow 2.3.3, TensorFlow 2.2.3 and TensorFlow 2.1.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by members of the Aivul Team from Qihoo 360.
References
- https://github.com/tensorflow/tensorflow/security/advisories/GHSA-jf7h-7m85-w2v2
- https://nvd.nist.gov/vuln/detail/CVE-2021-29605
- https://github.com/tensorflow/tensorflow/commit/7c8cc4ec69cd348e44ad6a2699057ca88faad3e5
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-cpu/PYSEC-2021-533.yaml
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow-gpu/PYSEC-2021-731.yaml
- https://github.com/pypa/advisory-database/tree/main/vulns/tensorflow/PYSEC-2021-242.yaml
- https://github.com/tensorflow/tensorflow
- https://github.com/tensorflow/tensorflow/blob/4ceffae632721e52bf3501b736e4fe9d1221cdfa/tensorflow/lite/c/common.c#L24-L27
Source: GitHub Advisory Database, used under CC BY 4.0.